search

geekitude / dokuwiki-plugin-userhomepage

Dokuwiki plugin to automatically create user's homepage and/or namespace
https://www.dokuwiki.org/plugin:userhomepage
5 stars 9 forks source link

fix usage of raw ACL configuration file #25

Closed e-picas closed 8 years ago

e-picas commented 8 years ago

You use a raw file path when loading ACL config (DOKU_CONF.'acl.auth.php') but DokuWiki can let user overwrite this path (like described on page https://www.dokuwiki.org/tips:farm for instance).

This fix only replaces the ACL path by the default DokuWiki core one: $config_cascade['acl']['default'].

It works great for me (with a custom file path) but needs to be tested in other cases.

geekitude commented 8 years ago

Hi... My first tests seem OK but the page you linked as a reference doesn't hold anything about changing ACL file path. Could you be a bit more specific ?

I'm not against that change but I'd like to read more about it.

Maybe you could explain why you relocated ACL file and where?

geekitude commented 8 years ago

However, all the tests I could think of were successfull => merging.

Thanks for that clean PR I'm still curious about the documentation about changing ACL file location ;)