search

geeklearningio / gl-vsts-tasks-file-patch

Visual Studio Team Services Build and Release Management extensions that help you update files using JSON patch and similar syntax
MIT License
21 stars 6 forks source link

Entries containing a slash can't be replaced #106

Open xanth opened 1 year ago

xanth commented 1 year ago

Before opening an issue please read this.

Are you reporting a bug or a feature request ?

Description

When replacing an entry value where the entry key contains a forward slash i.e. @angular/cli the tool erroneously throws OPERATION_PATH_UNRESOLVABLE errors. This seems to have been resolved in the fast-json-patch dependency so bumping that package should suffice.

Expected behavior

The value of an entry should be replaced.

Reproduction

See corrected test in PR: #105

cookbr commented 1 year ago

@sandorfr @asiffermann Any chance you can give the PR @xanth put up some of your time? I bumped into this today when I was looking to patch in a value for ...

metadata:
  labels:
    tags.datadoghq.com/version: FEED_ME_SEYMOUR

https://docs.datadoghq.com/getting_started/tagging/unified_service_tagging/?tab=kubernetes#full-configuration

cookbr commented 1 year ago

@arnaudauroux @sandorfr @mvidailhet @asiffermann Bump 🥺🙏