search

geeklearningio / gl-vsts-tasks-yarn

Yarn Package Manager Visual Studio Team Services Build and Release Management extensions
MIT License
52 stars 18 forks source link

yarnInstaller installs yarn 1.8 pre-release instead of yarn 1.7 stable #48

Closed blushingpenguin closed 6 years ago

blushingpenguin commented 6 years ago

yarnInstaller installs yarn 1.8 pre-release instead of yarn 1.7 stable

Are you reporting a bug or a feature request ?

Description

Yarn 1.8 pre-release is being installed by yarnInstaller when set to install "latest 1.x". It appears that this is due to:

https://geeklearningassets.blob.core.windows.net/yarn/tarballs.json

listing:

"v1.8.0":"https://github.com/yarnpkg/yarn/releases/download/v1.8.0/yarn-v1.8.0.tar.gz"

but:

https://github.com/yarnpkg/yarn/releases

shows it marked as pre-release. I'm unsure how the tarball is generated, but it is the reason that yarnInstaller is picking the pre-release version of yarn.

Expected behavior

yarn 1.7 should be used

System information

VSTS or TFS:

Agent:

OS:

Yarn version: *Yarn version** 1.8!

Thanks,

Mark

haukurk commented 6 years ago

+1

Had issues due to this as well!

edqwerty1 commented 6 years ago

+1 builds were broken... Removing version wildcard and forcing 1.7.0 as a workaround

k-schneider commented 6 years ago

Got hit with this today as well. Build server started bombing every job using this task.

sandorfr commented 6 years ago

Thanks for reporting this. It seems there are many sub issues to this one:

I'm mitigating the problem by removing the 1.7.0 and disabling the job which fetches releases for now.

The 1.8.0 is worrying me a bit more. Are you using vsts feeds or npm? Can you provide the error logs?

blushingpenguin commented 6 years ago

Did you mean removing 1.8? Should that ever have been in tarball.json (https://geeklearningassets.blob.core.windows.net/yarn/tarballs.json) given that it's pre-release?

I'm using VSTS, and the errors I was getting from building were simply that after "yarn install" there were missing packages.

sandorfr commented 6 years ago

Can you provide the logs? There is probably bugs to report to yarn.

On the version it's debatable, some people want the latest prerelease because they need it. I expected people to tweak the version pattern according to their needs. It is clearly not happening. So yes I'll add the capability to choose to include prerelease (and even nightlies) in the future. The default will become what you expected.

sandorfr commented 6 years ago

The 2.5.0 is out and solves the prerelease issue. There’s an option to get them back if you need.

The underlying issue in yarn has been fixed by them and will be part of 1.8.1