geekmaster / eyefiserver2

Automatically exported from code.google.com/p/eyefiserver2
0 stars 0 forks source link

Get rid of pyexiv2 #1

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I see you use pyexiv2 in the script. That is going to complicate things for me.
Alternatively, you could use file's creation date. The only problem, that the 
creation date is shifted by timezone twice (this must be EyeFi bug) so you have 
to adjust the time.
For example: 
Picture taken on 03:00 (GMT)
My time zone is +3

What I get:
Exif PictureTaken date 06:00(that is correct)
The images creation date in tar file is 09:00 (shifted second time).

I use eyefi server on my Qnap NAS and pyexiv2 is not installed on it. I have 
tried to compile it, but not successfully.

I would be grateful, if you make this lib optional. I will gladly share my 
alternative approach with you.

Original issue reported on code.google.com by vilius.s...@gmail.com on 16 May 2012 at 10:20

GoogleCodeExporter commented 8 years ago

Original comment by vilius.s...@gmail.com on 21 May 2012 at 8:39

GoogleCodeExporter commented 8 years ago
Ultimately I think I should probably make the EXIF file stamping an option in 
the config file, with a comment that says "pyexiv required."

Original comment by davidgrant on 22 May 2012 at 1:47

GoogleCodeExporter commented 8 years ago
I dont think pyexiv2 usage should be configurable as you can resolve its 
presence at runtime automatically.
Less config options = easier usage.

Original comment by vilius.s...@gmail.com on 22 May 2012 at 7:54

GoogleCodeExporter commented 8 years ago
Yeah I agree with that as well. The only problem is that currently it's a bit 
sneaky, there is no way for the user to know that this EXIF date-handling 
exists... but this can be fixed by adding some documentation to the homepage or 
a wiki page I think.

The big plus of what you did is that it is more likely that the script will 
"just work" even if they don't have the pyexiv2 dependency.

Original comment by davidgrant on 22 May 2012 at 4:00

GoogleCodeExporter commented 8 years ago
I will add a log message to the commandline on startup.

Original comment by vilius.s...@gmail.com on 22 May 2012 at 4:04

GoogleCodeExporter commented 8 years ago

Original comment by vilius.s...@gmail.com on 23 May 2012 at 9:30

GoogleCodeExporter commented 8 years ago

Original comment by vilius.s...@gmail.com on 19 Jun 2012 at 2:08