Closed SylvainDe closed 7 years ago
Hello @SylvainDe,
Thanks for taking the time to contribute to this project!
As per the CONTRIBUTING.md file this project requires that we first make changes to the develop branch and when fully tested we merge into master.
As such, can you please checkout that branch and resend your PR to that branch?
@mnemonicflow Sure, I'll do this as soon as possible. Before I go any further, can you confirm that you are happy with the config file as is ?
@SylvainDe Yes, your changes are fine.
Should I merge this?
@geeknam I guess https://github.com/geeknam/python-gcm/pull/119 should be merged first?
Yeah, I thought that we should merge all new things into develop branch first... Now if we merge the PR from the develop branch and then merge the develop branch into master we'll have two commits for the same thing
Add more recent Python versions including development branches and nightly build.
The motivation came from reading @brettcannon's article : https://snarky.ca/how-to-use-your-project-travis-to-help-test-python-itself/ . Trying to activate the newest Python versions on CI jobs is in most case a win-win situation: if everything works fine, there is nothing to worry about. If an issue is spotted, it is good to know about it to fix it on your side or to open a bug on CPython ( https://bugs.python.org/ ).
Also, if a failures is spotted, you can use the allow_failures option in your matrix build (more information about this in the link above).
Also, nightly and 3.7-dev may be a bit too recent/unstable so I can remove then if need be.
More information about how this PR happened on https://github.com/SylvainDe/CIthon .