Closed geeknam closed 9 years ago
Repository health increased by 2% when pulling 678a706 on feature/refactor into 9732576 on master.
Coverage is lower due to lots of lines being deleted thus increasing the % of uncovered loc.
@mnemonicflow I haven't done any manual testing. Can I leave this with you?
I'm going to test this
I've tested a few success and fail cases and it still works :+1:
I do not agree with 'Remove client side validations, let Google throw them in the HTTP response', but for now we should integrate as is. I think we should do as much client side validation as possible and only bother GCM servers when we can't determine on the client the correct outcome for a particular input.
Repository health decreased by 2% when pulling 5e08ce8 on feature/refactor into 9732576 on master.
2 minor problems introduced by merging #66 and #70, unused imports. Might want to fix that later, that should recover 2% from the repo health :)
construct_payload
method to use keyword argumentsplaintext_request
&json_request
methods to use keyword arguments