Refactor to use Payload classes

geeknam / python-gcm

Python client for Google Cloud Messaging for Android (GCM)

MIT License

458 stars 145 forks source link

Refactor to use Payload classes #80

Closed geeknam closed 9 years ago

geeknam commented 9 years ago

[x] Added Payload, PlaintextPayload, JsonPayload classes
[x] Refactored construct_payload method to use keyword arguments
[x] Refactored plaintext_request & json_request methods to use keyword arguments
[x] Remove client side validations, let Google throw them in the HTTP response

landscape-bot commented 9 years ago

Repository health increased by 2% when pulling 678a706 on feature/refactor into 9732576 on master.

No new problems were introduced.
4 problems were fixed (including 0 errors and 0 code smells).

geeknam commented 9 years ago

Coverage is lower due to lots of lines being deleted thus increasing the % of uncovered loc.

geeknam commented 9 years ago

@mnemonicflow I haven't done any manual testing. Can I leave this with you?

alibitek commented 9 years ago

I'm going to test this

alibitek commented 9 years ago

I've tested a few success and fail cases and it still works :+1:

I do not agree with 'Remove client side validations, let Google throw them in the HTTP response', but for now we should integrate as is. I think we should do as much client side validation as possible and only bother GCM servers when we can't determine on the client the correct outcome for a particular input.

landscape-bot commented 9 years ago

Repository health decreased by 2% when pulling 5e08ce8 on feature/refactor into 9732576 on master.

2 new problems were found (including 0 errors and 2 code smells).
4 problems were fixed (including 0 errors and 0 code smells).

geeknam commented 9 years ago

2 minor problems introduced by merging #66 and #70, unused imports. Might want to fix that later, that should recover 2% from the repo health :)