search

geekpgh / mastersproject

The masters project for SWENG 500 team 3
4 stars 2 forks source link

Comment Place Holder not working #87

Closed GIdeus closed 11 years ago

GIdeus commented 11 years ago

I do not know why, but the placeholder "Enter your comments (max 256 characters)" does not display.

If a user enters more than 256 characters they recieve an error message "An error occured". There is nothing to tell the user what the error is or that there is a 256 limit.

steveplatz commented 11 years ago

Good catch. I'll make sure to update everything. By the way, which browser are you using? The watermark could be the result of your browser not supporting that attribute.

Steve

Sent from my iPhone

On Jul 30, 2013, at 8:06 AM, GIdeus notifications@github.com wrote:

I do not know why, but the placeholder "Enter your comments (max 256 characters)" does not display.

If a user enters more than 256 characters they recieve an error message "An error occured". There is nothing to tell the user what the error is or that there is a 256 limit.

— Reply to this email directly or view it on GitHubhttps://github.com/geekpgh/mastersproject/issues/87 .

GIdeus commented 11 years ago

I am using IE 9.

steveplatz commented 11 years ago

That's interesting you were able to enter more than 256 characters. Do you have javascript disabled at all? There is a script set up to make sure you can't type more than 256 characters (it stops you once you reach that limit). The error should happen and I feel it's OK to show something generic if there are other protections in place. What do you think?

I also looked into the placeholder text and it appears that it isn't supported by IE9. If you feel it's important enough, we can use javascript plugins to do the same thing, but I was attempting to focus on standards and the path of least resistance when I implemented that change.

GIdeus commented 11 years ago

I don't know, I am not hitting a limit. I am running Windows 7 with IE9, Scripting of Java Applets is enabled. Is there something else? Mayby it's just me, if you are good with it close it.

geekpgh commented 11 years ago

I see the text on Windows 7 running FireFox 22.0.

The UI experience is actually pretty good right now. If I try to enter more than 256 characters it stops me from typing any more. If it also does that on IE 9, then I think we are good.

steveplatz commented 11 years ago

Could someone else comment on whether or not this works for them? Matt (John) or Geoff?

gmblogref commented 11 years ago

I can see the watermark in Windows 7 Firefox and chrome. It also stopped me when I got to 256 and wouldn't let me enter anymore characters. The only thing is that when I posted the comment it went clear off screen and not wrapped in the container.

GIdeus commented 11 years ago

Steve, I rechecked it with Firefox, and I get the watermark and it stops me at 256. It must be something about my IE9 ... or my computer is jacked up.

Geoff, the comment will only wrap if there are "words". If your comment is one long string without spaces then it cannot wrap.

geekpgh commented 11 years ago

I just tried this on IE 8 at work. Yes, we still have IE 8 shudder.

Here is what I see:

1) There is no water mark. 2) I can type as many characters as I want. 3) If I try to submit more than 256 characters I get a generic "An error has been encountered" but I am still on the page. 4) The word wrapping works just fine. 5) If I delete enough chars and hit enter the comment posts

I think perhaps making the error message say something like "You comment is too long, comments must be less then 256 characters" would fix this issue on older browsers.

steveplatz commented 11 years ago

That sounds good. On top of that, I'll see what I can do to get the javascript portion of this working with older browsers so that error message is only ever shown in the rarest of cases. Thanks for looking into that so thoroughly.