search

geekplux / markvis

make visualization in markdown. 📊📈
https://markvis.js.org/
MIT License
1.57k stars 61 forks source link

About Markvis-Pie Error #14

Closed jasperliu911 closed 1 year ago

jasperliu911 commented 1 year ago

image image

When I installed this plug-in in the project, I found that after entering a piece of pie chart syntax, the console output a series of errors. This error seems to be that the argument array has a length, but it is [' ']. I hope the author can see it reply to this question in a timely manner. Thanks

jasperliu911 commented 1 year ago

image Today I found the source code and found that the schemeCategory20d attribute does not exist in d3, only the schemeCategory10 attribute

jasperliu911 commented 1 year ago

image My D3 version is 7.8.5

jasperliu911 commented 1 year ago

image The D3 dependency package has removed the three attributes schemeCategory20b, schemeCategory20c, schemeCategory20 after version 4.13.0. So you need to change _d3.scaleOrdinal(_d3.schemeCategory20b) in the markvis-pie dependency package to _d3.scaleOrdinal(_d3 .schemeCategory10)

geekplux commented 1 year ago

Thanks for your found. Yes, this project is truly outdated, which is needed to update the deps.

geekplux commented 1 year ago

fixed by https://github.com/geekplux/markvis/commit/22005f48a2b6b6cb2f8ba11adeb9b51c3620e0a9