search

geekq / workflow

Ruby finite-state-machine-inspired API for modeling workflow
MIT License
1.75k stars 207 forks source link

Datamapper Integration #102

Closed plukevdh closed 10 years ago

plukevdh commented 10 years ago

Adds support for DataMapper. Tests fail because of the implicit dependency of ActiveRecord in ALL of the tests. See d36bf410c9746d696de33c77607a87434a0aafce for details.

plukevdh commented 10 years ago

Also incidentally includes failing tests for #74/#77

geekq commented 10 years ago

Thanks for your contribution!

I personally do not work with DataMapper. So unfortunately I can not take the responsibility for the maintenance of the DataMapper adapter. I suggest a separate gem like workflow-datamapper and would love to link to it from the workflow readme. At this occasion I also documented the way to support additional databases/adapters https://github.com/geekq/workflow#adapters-to-support-other-databases

Regarding "implicit dependency of ActiveRecord in ALL of the tests" I'll check it!

geekq commented 10 years ago

Regarding "implicit dependency of ActiveRecord in ALL of the tests":

I experimented a bit mit bundler and separate, minimal (without activerecord) Gemfile. Have not found the perfect way. So I would say, for development work on the workflow gem all the gems from Gemfile (including activerecord, sqlite3, ruby-graphviz) are required.

plukevdh commented 10 years ago

May move this. May drop it. Datamapper is sorta going the deprecation route. Closing this here for now.