Closed aserafin closed 4 months ago
Thanks for your contribution! Backward compatibility is very important (people have used this library for many years, and some do not upgrade to the newest Ruby or Rails versions). The compatibility should be covered (checked) by the test suite though. Good thing would be to switch from travis-CI (ceased) to GitHub actions, before integrating any new contributions. Maybe something inspired by https://github.com/geekq/workflow-activerecord/blob/develop/.github/workflows/test.yml so any regression can be prevented.
For the new behavior we'll need test cases as well.
Blocked by gh-229
Please rebase your PR, so we can see the results of the tests for different Ruby versions
Added unit tests, documentation, rebased and merged
This allows access to event arguments when we're evaluating which event to run in the scope of
@geekq I imagine this potentially is a breaking change but I run into a situation when event arguments had to be taken into account for conditional event - let me know what you think 👍 🙇