search

geekquad / AlgoBook

A beginner-friendly project to help you in open-source contributions. Data Structures & Algorithms in various programming languages Please leave a star ⭐ to support this project! ✨
https://discord.gg/ZMmwsWvsFj
MIT License
301 stars 303 forks source link

Fix possible integer overflow error in C++ binary search. #519

Closed Jakub-Kapusta closed 2 years ago

Jakub-Kapusta commented 2 years ago

Please see following ling for the details of the bug. https://medium.com/swlh/overflow-bug-in-binary-search-c4d4a824807a

geekquad commented 2 years ago

Hey @Jakub-Kapusta, thank you for bringing it up. Do you want to fix it?

Jakub-Kapusta commented 2 years ago

Hey @Jakub-Kapusta, thank you for bringing it up. Do you want to fix it?

The fix is provided in this pull request. Please let me know if there is anything you would like me to change.