issue to PR workflow - Githubissues

geeksblabla / awesome-morocco

👩‍💻 🇲🇦List of awesome Moroccan things for developers 🇲🇦👨🏻‍💻

https://awesome-morocco.dev/

657 stars 165 forks source link

issue to PR workflow #131

Closed soub4i closed 2 years ago

soub4i commented 2 years ago

This PR is related to #130

This PR will allow contributors to use issue templates to add the content to the website automatically.

TODO:

[X] Add templates
[x] Add tags new, community, event, blog, podcast, yt-channel, project, book
[x] Test the workflow

The generated file by this GitHub action is a JSON file like:

{"type":"blog","createdAt":1641764070591,"\"author_fullname":"xscezdze","author_contact":"dezjdizejd","author_handler":"jfenbrufheriufbe","blog_title":"fnierhfe_rgeur","blog_url":"hreufhuerfhuehferu","blog_rss":"dzeihzifh","description":"dzefhzihzihgz"}

netlify[bot] commented 2 years ago

✔️ Deploy Preview for awesome-morocco ready!

🔨 Explore the source changes: f945b31d76e2f17090ebdfde67f8ca35c5d7ca4c

🔍 Inspect the deploy log: https://app.netlify.com/sites/awesome-morocco/deploys/61f57dff7d0e6c0007ee032d

😎 Browse the preview: https://deploy-preview-131--awesome-morocco.netlify.app

soub4i commented 2 years ago

Hello @JefferyHus @yezz123 @yjose

I tested the Action and the results look good to me I think finished this step we can move forward to the next ones and is there any changes to please make a suggestion to the code directly so I can apply the patch directly

Regards

JefferyHus commented 2 years ago

Hello @JefferyHus @yezz123 @yjose

I tested the Action and the results look good to me I think finished this step we can move forward to the next ones and is there any changes to please make a suggestion to the code directly so I can apply the patch directly

Regards

Apart from my comments above, I don't see anything that could stop us from moving forward.

yjose commented 2 years ago

Great work @AbderrahimSoubaiElidrissi looks good so far, i would suggest scheduling a meeting next week to discuss the next steps. Meanwhile, i would suggest adding some unite tests for issue-parser script using jest.

yjose commented 2 years ago

@AbderrahimSoubaiElidrissi can we migrate the script to typescript as we are going to create more scripts and using typescript would be helpful to maintain them

soub4i commented 2 years ago

@yjose Exploring options to re-write the script in type script and as I used hashbang notation to make the file standalone there is a couple of options to choose from to achieve the same results:

Use a tsm an esbuild based module loader of typescript for node.js https://github.com/lukeed/tsm (as global dep)
Use tsm with hooks with node.js (as local dep)
Use Deno instead of node.js https://github.com/denoland/deno
Switch to other scripting languages the best candidate is python, Bash + sed

yjose commented 2 years ago

I Would recommend using tsm as local deps and using the following structure for the project


├── readme.md
├── contribution.md
├── website 
├── scripts 
       ├── package.json
       ├── tests
       ├── utils
       ├── 1-script.ts
       ├── 2-script.ts
├── content
       ├── sources // from pr 
       │   │   ├── blogs.yml
       │   │   └── repos.yml
       ├── data  // generated  json files

@AbderrahimSoubaiElidrissi WYT?

soub4i commented 2 years ago

@yjose LGTM. I will work on it

soub4i commented 2 years ago

@JefferyHus @yjose @yezz123 Pushed the progress not totally tested yet

JefferyHus commented 2 years ago

@JefferyHus @yjose @yezz123 Pushed the progress not totally tested yet

New changes looks good to me. Good work 👍

yjose commented 2 years ago

already merged to develop