geeksforsocialchange / PlaceCal

Bring your community together
https://placecal.org
GNU Affero General Public License v3.0
16 stars 6 forks source link

Improve datatables #1137

Open kimadactyl opened 2 years ago

kimadactyl commented 2 years ago

Is your feature request related to a problem? Please describe.

Currently, datatables only allow string content types. This is getting a bit janky and it would be nice to have fancier types. We should give this a spring clean and make it all nicer.

Describe the solution you'd like

Change the object passed to datatables to include potentially key, value and type. Make datatables prettier.

Describe alternatives you've considered

Replace the whole thing with Hotwire/Stimulus. This is not necessarily mutually exclusive - I think this will be good prep work for replacing later.

Additional context

Proposed column types and improvements this will allow

Would also like to have:

Implementation plan

Action taken

kimadactyl commented 2 years ago

1053 is related

kimadactyl commented 2 years ago

We could pay for this if it helps https://gorails.com/episodes/datatables-from-scratch-using-hotwire

kimadactyl commented 1 year ago

https://www.reddit.com/r/rails/comments/16vk9u0/whats_your_go_to_for_data_tables/

katjam commented 8 months ago

@geeksforsocialchange/developers Seems like maybe we have done some of this? I'm adding to Barriers to onboarding - but we might want to refactor the issue to take into account whether ticketed elsewhere, done or won'tfix / not a bit deal.

ivan-kocienski-gfsc commented 8 months ago

I think these are still valid.

I know kim wants us to roll our own fancy table display, which is a bit Dream Yard, but the other points would be easier cosmetic enhancements that'd make admin life easier.