search

geeksforsocialchange / PlaceCal

Bring your community together
https://placecal.org
GNU Affero General Public License v3.0
17 stars 8 forks source link

[Bug]: partner address linked #1615

Closed aaaaargZombies closed 1 year ago

aaaaargZombies commented 1 year ago

Description

quote from discord

so there's one contact who runs 2 groups - Queer Running Club & Pecs Education. When I change the address of one, it changes the address of the other. Any idea why this happens? these are the correct addresses

Pecs Education is here: Basis Ldn: 361-362 Warbuton street E8 3RR

Queer Running Club is here; Brunswick East Ground Floor, 17 Amhurst Terrace, Lower Clapton, E8 2BT

only obvious link in the admin UI seems to be the shared admin

Partner admins
1 user can edit this partner
    [kole.fulmine@gmail.com](https://admin.placecal.org/users/111/edit)

Steps to reproduce

  1. What you did first
  2. What you did next

What you expected to happen

What would you like to happen instead?

Platform (if relevant)

What device and browser were you using?

aaaaargZombies commented 1 year ago

A little poking around and it looks like the partner model takes an address_id so presumably when editing one of the partners it is the address model that gets updated and the reference stays the same.

I'm not sure how or why partners get assigned the same address_id - I guess this is usefull if a collective with working groups moves shop but less so in cases like this. Need to provide an warning about changing all linked addresses and give an option to "move out" if they are no longer sharing.