[Bug]: Partners visible on Sites they shouldn't be

[ivan-kocienski-gfsc]

Description

From the user: "Ecstatic Dance is linking to Ebb and Flow - why?? They aren’t linked in any other way"

Calendar "Ebb and Flow with Oshun" https://admin.placecal.org/calendars/133/edit

Partner "Ecstatic Dance" https://admin.placecal.org/partners/raquel-lopez/edit

Site "Conscious Collective Manchester" https://admin.placecal.org/sites/consciouscollectivemcr/edit

If you visit https://consciouscollectivemcr.placecal.org/partners you can see Sun Dance Manchester when you should not.

Notes

I suspect this is because the partner shares a service area neighbourhood with the site

[kimadactyl]

This feels critical to me and prob a sign of something bigger going on. But maybe we can fix another way in the short term?

[r-ferrier]

The original problem here is not an issue as this partner is in scope for this site - it has:

• an address or service area within this sites' neighbourhood
• a partnership tag belonging to this site

HOWEVER a different kind of linked problem does exist:

http://<NEIGHBOURHOOD_SITE>.placecal.org/partners/<PARTNER_OUTSIDE_NEIGHBOURHOOD> is a valid route when it should not be.

[kimadactyl]

Dupe of https://github.com/geeksforsocialchange/PlaceCal/issues/1386