r-ferrier
commented
1 year ago The error
partner params used to get back neighbourhood info
Parameters: {"authenticity_token"=>"pf2QNF7WSv1zlhdRwOnLLD8kWiQLBMq7OBrQqbZmevDcxKTCmS-FJ_Sd2WSylayJ9zBMEGksMK4JRv0vuXxpoA", "partner"=>{"name"=>"Test Partner broken address", "slug"=>"test-partner-broken-address", "summary"=>"", "description"=>"", "accessibility_info"=>"", "address_attributes"=>{"street_address"=>"Test address", "street_address2"=>"", "street_address3"=>"", "city"=>"", "postcode"=>"EC1V 2NX", "id"=>"983253"}, "url"=>"", "facebook_link"=>"", "twitter_handle"=>"", "public_name"=>"", "public_email"=>"", "public_phone"=>"", "partner_name"=>"", "partner_email"=>"", "partner_phone"=>"", "opening_times"=>"[]", "tag_ids"=>[""]}, "commit"=>"Save Partner", "subdomain"=>"admin", "id"=>"test-partner-broken-address"}the bit that is breaking
app/controllers/admin/partners_controller.rb:72:in `update'
09:16:02 web.1 | Neighbourhood Load (4.8ms) SELECT "neighbourhoods".* FROM "neighbourhoods" WHERE "neighbourhoods"."unit" = $1 AND "neighbourhoods"."unit_code_key" = $2 AND "neighbourhoods"."unit_code_value" = $3 AND "neighbourhoods"."unit_name" = $4 LIMIT $5 [["unit", "ward"], ["unit_code_key", "WD19CD"], ["unit_code_value", "E05013699"], ["unit_name", "Bunhill"], ["LIMIT", 1]]
09:16:02 web.1 | ↳ app/models/neighbourhood.rb:108:in `find_from_postcodesio_response'
09:16:02 web.1 | Partner Exists? (1.6ms) SELECT 1 AS one FROM "partners" WHERE LOWER("partners"."name") = LOWER($1) AND "partners"."id" != $2 LIMIT $3 [["name", "Test Partner broken address"], ["id", 246], ["LIMIT", 1]]
09:16:02 web.1 | ↳ app/controllers/admin/partners_controller.rb:72:in `update'
09:16:02 web.1 | CACHE Neighbourhood Load (0.0ms) SELECT "neighbourhoods".* FROM "neighbourhoods" WHERE "neighbourhoods"."unit" = $1 AND "neighbourhoods"."unit_code_key" = $2 AND "neighbourhoods"."unit_code_value" = $3 AND "neighbourhoods"."unit_name" = $4 LIMIT $5 [["unit", "ward"], ["unit_code_key", "WD19CD"], ["unit_code_value", "E05013699"], ["unit_name", "Bunhill"], ["LIMIT", 1]]
09:16:02 web.1 | ↳ app/models/neighbourhood.rb:108:in `find_from_postcodesio_response'
09:16:02 web.1 | (4.3ms) SELECT COUNT(*) FROM "tags" INNER JOIN "partner_tags" ON "tags"."id" = "partner_tags"."tag_id" WHERE "tags"."type" = $1 AND "partner_tags"."partner_id" = $2 [["type", "Category"], ["partner_id", 246]]
09:16:02 web.1 | ↳ app/models/partner.rb:370:in `three_or_less_category_tags'
09:16:02 web.1 | TRANSACTION (1.4ms) ROLLBACKWhat is happening to cause this
We create and update a partner. While updating the partner, in a before_action, we get the neighbourhoods from the partner and set them.
app/controllers/admin/partners_controller.rb line 114
def set_service_area_map_ids
# maps neighbourhood ID to service_area ID
@service_area_id_map = if @partner
@partner
.service_areas.select(:id, :neighbourhood_id)
.map { |sa| { sa.neighbourhood_id => sa.id } }
.reduce({}, :merge)
else
{}
end
endWe validate address updates in the neighbourhood with: (in app/models/address.rb, line 78, def geocode_with_ward)
# There shouldn't be any wards that are outside our system, if there are we just fail.
neighbourhood = Neighbourhood.find_from_postcodesio_response(res)
if neighbourhood.nil?
errors.add :postcode, 'has been found but could not be mapped to a neighbourhood at this time'
return
endwe use this to find a neighbourhood app/models/neighbourhood.rb line 107
Neighbourhood.find_by(
unit: 'ward',
unit_code_key: 'WD19CD',
unit_code_value: res['codes']['admin_ward'],
unit_name: res['admin_ward']
)
ivan-kocienski-gfsc
Description
Some valid addresses cannot be added to the site.
Steps to reproduce
Why we think this is happening
We have saved a 2019 database as a csv containing lists of postcodes and the wards they are associated with. When someone uploads a postcode to our site, we use this database to retrieve the ward id for this postcode. We then cross reference this ward id at postcode.io to access further data about the ward. In some instances, this data is not being retrieved. My first guess at likely causes is:
Approaches we may try
We want to be careful not to break existing working definitions of wards. If your site is set up based around a locale and the boundaries change regularly this is probably not helpful - users may prefer to define which ward a partner belongs to. So we could:
Other things to consider
How does this operate in a location outside of the UK? How tightly coupled to this specific data set are our geographic definitions and can we loosen this?
Plan
First pass (getting everything working again)
Second pass (allowing selection of different wards)