Remove unused tables / models

[ivan-kocienski-gfsc]

Description

There are a number of tables that get created in the database bring-up that aren't used in the code and should be removed.

Motivation

They take up time/space in code and are confusing when trying to read code.

Acceptance criteria

• [ ] only tables that are required for the functioning of PC today should be present after a DB build.
• [ ] no unused models

Developer notes

• remove tables places and partner_places (these are just tables)
• remove Organisation Relationship table / model / relations

Follow on work

Leave the rest of the tables / models for review and possible clear out.

Tasks

• [ ] #2255
• [ ] Investigate (/ Remove?) supporters model
• [ ] Investigate (/ Remove?) Organisation relationship model
• [x] #2258

[ivan-kocienski-gfsc]

Tables that exist that have no models

• places
• partner_places

Organisation relationship

• has model
• joins partners to each other (subject -> object)
• is not used outside of partner model (the relation accesser is not touched in any other code)
• has only one reference in tests

Collections

• had model
• tied to site
• has admin interface
• public interface is minimal and likely defunct
• has lots of unused code in public controller
• has tests

Supporters

• has model
• tied to site
• has admin interface
• is used in footer

[r-ferrier]

We think this needs the following to progress:

• research about where these things are still referred to in the codebase and what function they perform
• a discussion with someone in a more product owner type role about whether or not these are still useful
• possibly scope out features that places were supposed to cover but are no longer serving or in use

[ivan-kocienski-gfsc]

Had a chat with @kimadactyl and we have PO sign off.

Will investigate the code to see what needs to be touched.

[kimadactyl]

i would say the organisation relationship thing is useful if unused atm and maybe a sep discussion

we get asked for things like this A LOT by people with money so it could be a sooner than later ticket https://github.com/geeksforsocialchange/PlaceCal/issues/1215

again if we want to remake fine but i think it might be more effort than its worth to disentangle

[ivan-kocienski-gfsc]

We did a bit of digging and the organisation relation is used e.g. here. There is an issue touching this. And there is a dump of the entire table.

[kimadactyl]

yeah i would not tug at this one right now personally!