geeksforsocialchange / PlaceCal

Bring your community together
https://placecal.org
GNU Affero General Public License v3.0
17 stars 8 forks source link

[Bug]: Link in Partner header to site where it appears needs to be absolute #2288

Closed katjam closed 7 months ago

katjam commented 8 months ago

Description

Using the link in the header to view PlaceCal instance where a Partner appears

image

Is coming up as: https://admin.placecal.org/partners/ambitions-graveyard/norwich.placecal.org

Should be: https://norwich.placecal.org

A/C

kimadactyl commented 8 months ago

I think the link text could be clearer, too. Maybe "View this partner on: Norwich, Trans Dimension". Also make sure it opens in a new tab so perhaps add "open in new tab)"?

katjam commented 7 months ago

Adding to milestone as we will be working on edit form #2408

ivan-kocienski-gfsc commented 7 months ago

Okay so this problem is because the URL field on sites has some wild data in it. could be a URL, could be a slug.

Currently we have

[1] "Marvellous Mossley" "https://mossley.placecal.org"
[2] "PlaceCal Hulme" "https://hulme.placecal.org"
[3] "PlaceCal Moss Side" "https://moss-side.placecal.org"
[11] "PlaceCal Ardwick" "ardwick.placecal.org"
[5] "PlaceCal" "placecal.org"
[4] "PlaceCal Rusholme" "https://rusholme.placecal.org"
[8] "PlaceCal Beeston" "https://beeston.placecal.org"
[9] "PlaceCal Christchurch" "https://christchurch.placecal.org"
[13] "PlaceCal West Vale" "westvale.placecal.org"
[6] "PlaceCal Moston" "https://moston.placecal.org"
[12] "OL1 Oldham" "ol1.placecal.org"
[14] "PlaceCal London" "https://london.placecal.org"
[10] "PlaceCal East Berwickshire" "https://berwickshire.placecal.org"
[17] "The Trans Dimension" "https://transdimension.uk"
[29] "Climate Justice North East" "https://climatejustice.placecal.org"
[18] "C2 Connecting Communities" "c2.placecal.org"
[16] "GM Systems Changers" "https://gmsc.placecal.org"
[23] "Flourish Together" "https://flourish.placecal.org"
[20] "Test Site" "test-site"
[22] "PlaceCal Oldham" "https://oldham.placecal.org"
[28] "Care in Common" "https://care-in-common.placecal.org"
[24] "Conscious Collective Manchester" "https://consciouscollectivemcr.placecal.org"
[27] "PlaceCal Exeter" "exeter.placecal.org"
[21] "PlaceCal Manchester" "https://manchester.placecal.org"
[19] "PlaceCal Torbay" "torbay"
[25] "Norwich" "norwich.placecal.org"
[30] "Manchester Independent Venues" "https://musicvenuetrust.placecal.org"
aaaaargZombies commented 7 months ago

Maybe just clean up this data while your in there

[11] "PlaceCal Ardwick" "ardwick.placecal.org"
[5] "PlaceCal" "placecal.org"
[13] "PlaceCal West Vale" "westvale.placecal.org"
[12] "OL1 Oldham" "ol1.placecal.org"
[18] "C2 Connecting Communities" "c2.placecal.org"
[20] "Test Site" "test-site"
[27] "PlaceCal Exeter" "exeter.placecal.org"
[19] "PlaceCal Torbay" "torbay"
[25] "Norwich" "norwich.placecal.org"
r-ferrier commented 7 months ago

No code changes were required so marking as wontfix