geeksforsocialchange / PlaceCal

Bring your community together
https://placecal.org
GNU Affero General Public License v3.0
17 stars 6 forks source link

[Bug]: user set model slugs are lost if saving a record #2358

Open ivan-kocienski-gfsc opened 6 months ago

ivan-kocienski-gfsc commented 6 months ago

Description

We use slugs on Partners, Tags and Sites.

We use a gem called FriendlyId.

The problem is when editing a model, if the user sets a custom slug value and (with invalid values elsewhere) saves then the they are taken back to the form but the user provided slug value has not been persisted.

katjam commented 6 months ago

I think I saw somewhere that @kimadactyl suggests not letting folks edit the slugs.

kimadactyl commented 6 months ago

Yes - i think the real problem here is that rach shouldn't be a root user