[Bug]: filter switcher on `our work` rendered inoperable if JS doesn't load or is disabled

[aaaaargZombies]

Description

filter switcher on our work rendered inoperable if JS doesn't load or is disabled, consider rendering in open state statically then hiding once JS runs so it is ugly but functional as fallback.

Steps to reproduce

1. What you did first
2. What you did next

Platform (if relevant)

What device and browser were you using?

[kimadactyl]

do we care? im not sure what modern logic is on if people having js disabled is a real thing we need to care about

[katjam]

It is still considered good practice to provide a graceful alternative state for js driven content. Particularly if the site is otherwise static content.

On Mon, 10 Jul 2023, 16:09 Dr Kim Foale, @.***> wrote:

do we care? im not sure what modern logic is on if people having js disabled is a real thing we need to care about

— Reply to this email directly, view it on GitHub https://github.com/geeksforsocialchange/gfsc-v3/issues/328#issuecomment-1629163693, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGSH5DOV7WRLMACMGZA52DXPQLL7ANCNFSM6AAAAAA2EOTTCM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[kimadactyl]

considered by who? not trying to be difficult i just want to know more about motivation. noone is asking sites to work without CSS, for example

[katjam]

It may be something we don't want to support but it should be a deliberate decision we make. People do also access sites as plain text (no CSS). I'll dig put some references.

On Mon, 10 Jul 2023, 17:09 Dr Kim Foale, @.***> wrote:

considered by who? not trying to be difficult i just want to know more about motivation. noone is asking sites to work without CSS, for example

— Reply to this email directly, view it on GitHub https://github.com/geeksforsocialchange/gfsc-v3/issues/328#issuecomment-1629263362, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGSH5CQPJ5UBRD6LROWFCLXPQSJZANCNFSM6AAAAAA2EOTTCM . You are receiving this because you commented.Message ID: @.***>

[r-ferrier]

I think we can do this with css (https://stackoverflow.com/questions/6019845/show-hide-div-on-click-with-css ) so I'm going to investigate but will not spend a huge amount of time on this.

Although I can definitely see the argument for a largely static site running nicely without js, I think I'm with Kim on this issue and I'm especially against defaulting to all options on this page because once the js loads a split second later it will change the appearance, which will be really jarring for 99% of our visitors.

Also although you can't search by project type on this page if it doesn't load, you can still view every project, which feels like a decent enough fallback to me?

[r-ferrier]

Css: just because we can, in this instance, I do not think we should! Too many accessibility inconsistencies would be introduced.

We've decided to not fix this in this sprint using js because the only simple option would introduce a page jump on load.