search

geeksforsocialchange / imok

A simple bot to support people doing risky activities
https://gfsc.studio/blog/2021/imok-is-launched/
MIT License
11 stars 1 forks source link

WIP: Convert gdoc features to Gherkins #10

Closed kimadactyl closed 3 years ago

kimadactyl commented 3 years ago

Lots of work here to do still but just wanted to check I'm on the right track

wheresalice commented 3 years ago

I've pushed an update to this branch which makes a few of these tests pass and adds some TODOs for others that aren't easy to test.

Note that this also introduces a new Member field, is_ok, which is an optional Boolean. So migrations will need running to test this.

wheresalice commented 3 years ago

All tests passing except:

NotImplementedError: STEP: Then the attempt is logged

Should this be logged to the database so that admins can review it?

There are some caveats to some of the tests. Should I raise Asana tickets for them?

kimadactyl commented 3 years ago

Asana is great yeah sorry I've not configured that yet. Jot some stuff down and I'll get to it this week.

kimadactyl commented 3 years ago

Maybe for that notification specifically an email is more appropriate?