chore: Update server messages to desired states

geeksforsocialchange / imok

A simple bot to support people doing risky activities

https://gfsc.studio/blog/2021/imok-is-launched/

MIT License

11 stars 1 forks source link

chore: Update server messages to desired states #29

Closed kimadactyl closed 3 years ago

kimadactyl commented 3 years ago

[x] Make Kim's new tests pass
[x] Add new registration message to tests and update code to match
[ ] Confirm that ok statuses are the right way around and rename to simply yes / maybe / no
[ ] Review translator's notes

kimadactyl commented 3 years ago

Note to add "Translators note: feel free to change this to a similar sentiment in your culture" to the "check out" text above "I hope you have a lovely day!" so it can be seen in POEditor (prob will be something like "Go with God" in Arabic etc)

kimadactyl commented 3 years ago

I missed the new user registration message:

You've been invited to join %(server name)!

Would you like to register for this service?

Reply YES to join.

wheresalice commented 3 years ago

All tests are passing, but there's some still some TODOs that need resolving, and it's not using the agreed date/time formats everywhere yet.

kimadactyl commented 3 years ago

Just checking you saw my comment TODOs asking if the is_ok status are the right way around or not?

I would have thought it would be:

Not checked in - OK
Checked in - Maybe OK
Alarm raised / timer elapsed - Not OK

I think it might be back to front atm unless I'm reading wrong?

In fact while we're at it maybe let's make these simpler: 'Yes', 'Maybe', and 'No'. (Perhaps this is a new ticket)