bug: "Resend SMS invite" doesn't work if default channel is set to Telegram

geeksforsocialchange / imok

A simple bot to support people doing risky activities

https://gfsc.studio/blog/2021/imok-is-launched/

MIT License

11 stars 1 forks source link

bug: "Resend SMS invite" doesn't work if default channel is set to Telegram #30

Closed kimadactyl closed 3 years ago

kimadactyl commented 3 years ago

Overview

The "Resend SMS invite" action in the Django admin menu doesn't actually send an SMS, it sends a message on the current default channel for that user.

Acceptance Criteria

[ ] Add one action per server-enabled communication channel to the Django dropdown
[ ] Clicking each button sends a notification on that channel

wheresalice commented 3 years ago

It doesn't really make sense to send or re-send an invite via Telegram. It will only actually reach the recipient if they have already interacted with the Telegram bot.

So should the action always send via SMS, and give an error if there is no phone_number defined?

kimadactyl commented 3 years ago

Yeah that sounds fine :)