geeksforsocialchange / imok

A simple bot to support people doing risky activities
https://gfsc.studio/blog/2021/imok-is-launched/
MIT License
12 stars 1 forks source link

fix: simplify the way we handle ok status #57

Closed wheresalice closed 3 years ago

wheresalice commented 3 years ago

This PR simplifies ok statuses to True/False

is_ok defaults to true, and is set to False by the healthcheck detecting them as overdue or them sending SOS.

Some additional admin actions have been added to the Members model:

State Model.pdf

wheresalice commented 3 years ago

If it's just a case of changing the text in the admin screen then that's just adding a verbose name, which I've just done.

It is more fiddly to change the actual name of the field.

kimadactyl commented 3 years ago

Hmm I feel like I'd want the tests to reflect safe/unsafe and the messages to admins. So the field could stay the same name but the text used to display it not? Is that a lot?

wheresalice commented 3 years ago

Updated tests and display text to use safe/not safe instead of ok/not ok