[Bug]: contact from partner by tag not resolving (probably a missing address?)

geeksforsocialchange / the-trans-dimension

The Trans Dimension is an online community hub connecting trans communities in the UK.

http://transdimension.uk

Other

3 stars 1 forks source link

[Bug]: contact from partner by tag not resolving (probably a missing address?) #400

Closed katjam closed 6 months ago

katjam commented 6 months ago

Site build failing

18:07:54.891 | I encountered some errors while decoding this JSON:
-- | --
18:07:54.891 |  
18:07:54.891 | At path /data/partnersByTag/24/contact
18:07:54.891 |  
18:07:54.891 | I expected an object here, but instead found this value:
18:07:54.892 |  
18:07:54.892 | null
18:07:54.892 |  
18:07:54.892 | At path /data/partnersByTag/24/contact
18:07:54.892 |  
18:07:54.892 | I expected an object here, but instead found this value:

katjam commented 6 months ago

@GeorgieMcVicar Wanted to give you a heads up that the Trans Dimension site is failing to re-build with new data since yesterday, It looks like maybe some contact details missing for a partner, if that rings a bell with any edits you've done recently.

I'll look into it tomorrow. It should not be possible to save data in PlaceCal that the site can't handle so I'll fix it on the Trans Dimension side, regardless.

GeorgieMcVicar commented 6 months ago

Thanks - let me know how it goes :)

katjam commented 6 months ago

It looks like the issue is with Material Grrrlz data. I have made a fix locally that works but it has also made me look into where and how we display those contact details. So I don't want to rush out the fix. I will release tomorrow.

katjam commented 6 months ago

If we want to fix with the data then I think we can edit Material Grrrlz I'll take a look and see if I can quickly do that.

katjam commented 6 months ago

I can't immediately see what the difference with their data is. They do have contact details, but not coming through.

katjam commented 6 months ago

There is a problem with the data coming from PlaceCal, I think. I have amended the code to expect Contact details to maybe not be there - but in this case They are there, just not coming through.

katjam commented 6 months ago

I am hoping that @kimadactyl agrees, I plan to merge this "fix" that allows the details to be missing so that the build can continue to work. Next week we'll make some time to look at the issue in PlaceCal.

kimadactyl commented 6 months ago

Agree yes this seems important to fix! Maybe let's start a mini milestone?