WIP filter functionality

geeksforsocialchange / two-towers

The Project Formally Known As RAFTT

https://towersoldham.uk/

0 stars 1 forks source link

Closed aaaaargZombies closed 1 year ago

aaaaargZombies commented 1 year ago

Fixes #129

[x] A timeline item has a contributor data attribute
[x] The homepage has a filters section
[x] The filters section on the homepage can be opened and closed
[x] The filters section has a list of content types
[x] The filters section has a list of authors & authors have the total number of stories next to them
[x] When a filter button is clicked only that content is shown & only one can be clicked at a time
[x] The filters section is sticky
[x] The close button on the filters section clears filters and closes

@geeksforsocialchange/developers

ivan-kocienski-gfsc commented 1 year ago

This works but it looks like you have some z bugs

Screenshot_2023-05-16_16-19-13

ivan-kocienski-gfsc commented 1 year ago

Would it be possible to have the "close filter" button appear in the same place as the "open filter" button (in case i accidentally tap on it) ?

cloudflare-workers-and-pages[bot] commented 1 year ago

Latest commit:	`a1e85b9`
Status:	✅ Deploy successful!
Preview URL:	https://53f979e3.raftt.pages.dev
Branch Preview URL:	https://147-open-close-filter-sectio.raftt.pages.dev

aaaaargZombies commented 1 year ago

Would it be possible to have the "close filter" button appear in the same place as the "open filter" button (in case i accidentally tap on it) ?

ask Emma!

undividual commented 1 year ago

I can't see why not!

aaaaargZombies commented 1 year ago

Looks okay to me. might want to trim out those console.log lines tho

good catch, I will do before merging