Closed ivan-kocienski-gfsc closed 1 year ago
Latest commit: |
602d219
|
Status: | ✅ Deploy successful! |
Preview URL: | https://b92fade1.raftt.pages.dev |
Branch Preview URL: | https://ik-65-share-link.raftt.pages.dev |
At the moment when I click the 'share' link it just hops me to the top of that story in the timeline. Is there a way of getting it to pop up the URL to copy and paste rather than taking us directly to it? (I imagine this is what you're working on next, so no need to respond to me, just confirming that's what needs to happen!)
For zero code this is how 'share' links work. you just have to right-click and 'copy link'
Okay, but for the end user we will need this to be much clearer? Remember this site is for use by like, yer nana, on her first ipad, and she sees a thing she thinks is cool and wants to email it to her daughter. She needs as clear an interface as possible to get the link. I attach my design for a pop up here again for ref — it includes both the link and an explainer of what that link is for! (The white box is where the link would go)
I think as the minimal viable option this is good but doesn't close the issue. I'd like to see a couple of changes before merging.
The implementation notes say @katjam has some code examples to add functionality so hopefully they will provide them so we can make a snazzier version too.
So @aaaaargZombies is what you're saying that instead of just 'share' it should say 'copy link to share'? I worry this is still too complex for some people, is the pop up option I sketched out way too arduous to implement? Because basically it would have to say 'Right click and click 'copy link' then paste this link into a message to share' in order to fully explain it to some less experienced users, clearly this is WAY too much text!
I think the idea of telling people there is a URL they can copy into their social media feed is already asking a lot of them technically. my nan has no idea what a url is.
anywho i have made it so when you click on the 'share' link it pops up a big yellow box telling you it has been copied to the clipboard.
This code should then be adapted in future
this is nice!
Just the icon color and it's good to go!
Fixes #65
Description
Really simple "Share" link people can copy to link directly to parts of the story page.
Styling TBD
@geeksforsocialchange/developers