search

geeksville / steamback

A Decky plugin to add versioned save-game snapshots to Steam-cloud enabled games.
GNU General Public License v3.0
63 stars 4 forks source link

A couple of bugs in defaults/py_modules/steamback/__init__.py #72

Closed Gadgetoid closed 8 months ago

Gadgetoid commented 8 months ago

Found with ruff check:

plugins/Steamback/defaults/py_modules/steamback/__init__.py:578:43: F821 Undefined name `f`
plugins/Steamback/defaults/py_modules/steamback/__init__.py:660:34: F821 Undefined name `saveInfo`

Former at https://github.com/geeksville/steamback/blob/7870bc8cf5983ebca3b581bc4dc30e25d23c14b6/defaults/py_modules/steamback/__init__.py#L578 should be filename, I think?

Latter at https://github.com/geeksville/steamback/blob/7870bc8cf5983ebca3b581bc4dc30e25d23c14b6/defaults/py_modules/steamback/__init__.py#L660 should be save_info.

Other potential issues as of the latest plugin database version, though I have not checked these are still in main:

plugins/Steamback/defaults/py_modules/steamback/__init__.py:410:25: E741 Ambiguous variable name: `l`
plugins/Steamback/defaults/py_modules/steamback/__init__.py:432:16: E713 [*] Test for membership should be `not in`
plugins/Steamback/defaults/py_modules/steamback/__init__.py:573:36: F541 [*] f-string without any placeholders
plugins/Steamback/defaults/py_modules/steamback/__init__.py:736:41: F841 [*] Local variable `e` is assigned to but never used
plugins/Steamback/defaults/py_modules/steamback/__init__.py:740:33: F841 [*] Local variable `e` is assigned to but never used
plugins/Steamback/defaults/py_modules/steamback/__main__.py:32:17: F541 [*] f-string without any placeholders
plugins/Steamback/defaults/py_modules/steamback/__main__.py:75:5: F841 Local variable `all_games` is assigned to but never used
plugins/Steamback/defaults/py_modules/steamback/gui.py:48:16: E713 [*] Test for membership should be `not in`
plugins/Steamback/defaults/py_modules/steamback/gui.py:128:9: F841 Local variable `s_sb` is assigned to but never used
plugins/Steamback/defaults/py_modules/steamback/test.py:2:8: F401 [*] `sys` imported but unused
plugins/Steamback/defaults/py_modules/steamback/test.py:3:8: F401 [*] `os` imported but unused
plugins/Steamback/defaults/py_modules/steamback/test.py:4:8: F401 [*] `asyncio` imported but unused
plugins/Steamback/defaults/py_modules/steamback/test.py:18:11: F541 [*] f-string without any placeholders
plugins/Steamback/defaults/py_modules/steamback/util.py:4:8: F401 [*] `os` imported but unused
plugins/Steamback/main.py:2:8: F401 [*] `json` imported but unused
plugins/Steamback/main.py:3:8: F401 [*] `time` imported but unused
plugins/Steamback/main.py:5:8: F401 [*] `shutil` imported but unused
plugins/Steamback/main.py:7:8: F811 Redefinition of unused `re` from line 1
plugins/Steamback/main.py:7:8: F401 [*] `re` imported but unused
plugins/Steamback/main.py:9:21: F401 [*] `pathlib.Path` imported but unused
plugins/Steamback/tests/fonttest.py:14:9: F841 Local variable `label` is assigned to but never used
geeksville commented 8 months ago

Oh my. Thanks! I'll reply when back at keyboard tomorrow.

(Sent from a phone - please ignore typos)

On Sun, Feb 18, 2024, 14:47 Philip Howard @.***> wrote:

Found with ruff check:

plugins/Steamback/defaults/py_modules/steamback/init.py:578:43: F821 Undefined name f plugins/Steamback/defaults/py_modules/steamback/init.py:660:34: F821 Undefined name saveInfo

Former at https://github.com/geeksville/steamback/blob/7870bc8cf5983ebca3b581bc4dc30e25d23c14b6/defaults/py_modules/steamback/__init__.py#L578 should be filename, I think?

Latter at https://github.com/geeksville/steamback/blob/7870bc8cf5983ebca3b581bc4dc30e25d23c14b6/defaults/py_modules/steamback/__init__.py#L660 should be save_info.

Other potential issues as of the latest plugin database version, though I have not checked these are still in main:

plugins/Steamback/defaults/py_modules/steamback/init.py:410:25: E741 Ambiguous variable name: l plugins/Steamback/defaults/py_modules/steamback/init.py:432:16: E713 [] Test for membership should be not in plugins/Steamback/defaults/py_modules/steamback/init.py:573:36: F541 [] f-string without any placeholders plugins/Steamback/defaults/py_modules/steamback/init.py:736:41: F841 [] Local variable e is assigned to but never used plugins/Steamback/defaults/py_modules/steamback/init.py:740:33: F841 [] Local variable e is assigned to but never used plugins/Steamback/defaults/py_modules/steamback/main.py:32:17: F541 [] f-string without any placeholders plugins/Steamback/defaults/py_modules/steamback/main.py:75:5: F841 Local variable all_games is assigned to but never used plugins/Steamback/defaults/py_modules/steamback/gui.py:48:16: E713 [] Test for membership should be not in plugins/Steamback/defaults/py_modules/steamback/gui.py:128:9: F841 Local variable s_sb is assigned to but never used plugins/Steamback/defaults/py_modules/steamback/test.py:2:8: F401 [] sys imported but unused plugins/Steamback/defaults/py_modules/steamback/test.py:3:8: F401 [] os imported but unused plugins/Steamback/defaults/py_modules/steamback/test.py:4:8: F401 [] asyncio imported but unused plugins/Steamback/defaults/py_modules/steamback/test.py:18:11: F541 [] f-string without any placeholders plugins/Steamback/defaults/py_modules/steamback/util.py:4:8: F401 [] os imported but unused plugins/Steamback/main.py:2:8: F401 [] json imported but unused plugins/Steamback/main.py:3:8: F401 [] time imported but unused plugins/Steamback/main.py:5:8: F401 [] shutil imported but unused plugins/Steamback/main.py:7:8: F811 Redefinition of unused re from line 1 plugins/Steamback/main.py:7:8: F401 [] re imported but unused plugins/Steamback/main.py:9:21: F401 [] pathlib.Path imported but unused plugins/Steamback/tests/fonttest.py:14:9: F841 Local variable label is assigned to but never used

— Reply to this email directly, view it on GitHub https://github.com/geeksville/steamback/issues/72, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXB2LVVUJS3ZGICDVHAYDYUKAI7AVCNFSM6AAAAABDOQBSQ2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2DCMRSGI2TSNI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Gadgetoid commented 8 months ago

You're welcome- I was running some checks across decky-plugin-database and all submodules while I waited for approval on my plugin 😆, and these bugs looked like they might correspond to some open issues maybe perhaps.