geeksville / steamback

A Decky plugin to add versioned save-game snapshots to Steam-cloud enabled games.
GNU General Public License v3.0
61 stars 4 forks source link

Option to manually take a snapshot #73

Open goncalossilva opened 5 months ago

goncalossilva commented 5 months ago

First of all, thanks for creating Steamback! It has saved me from poor in-game decisions a couple of times. 😄

Have you considered adding an option to Steamback's menu to manually take a snapshot?

Like many other players, I seldom exit the game I'm currently playing until I'm done. Having a manual option would allow taking snapshots without having to exit and re-launch the game, which is slow and disruptive. With this option, Steamback would cater to players who currently can't leverage it as much due to how they use their Steam Deck.

geeksville commented 5 months ago

oh good idea. Though users would have to be a bit careful in that circumstance (because might not work well with some games). I'll try to get this in the next release (which should be in the next couple of weeks.

On Sat, Feb 24, 2024 at 4:52 PM Gonçalo Silva @.***> wrote:

First of all, thanks for creating Steamback! It has saved me from poor in-game decisions a couple of times. 😄

Have you considered adding an option to Steamback's menu to manually take a snapshot?

Like many other players, I seldom exit the game I'm currently playing until I'm done. Having a manual option would allow taking snapshots without having to exit and re-launch the game, which is slow and disruptive. With this option, Steamback would cater to players who currently can't leverage it as much due to how they use their Steam Deck.

— Reply to this email directly, view it on GitHub https://github.com/geeksville/steamback/issues/73, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXB2NSKDNI6QKDEZ3KAETYVKDLNAVCNFSM6AAAAABDYNH3SKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2TENJUGI4DSMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

geeksville commented 5 months ago

ok now pushed to the decky store. It usually takes them a couple of weeks to push it to testing store and then sometime after to the 'stable' store. You can track the progress here. https://github.com/SteamDeckHomebrew/decky-plugin-database/pull/556

goncalossilva commented 5 months ago

Excellent, looking forward to it!

geeksville commented 5 months ago

@goncalossilva would you be willing to switch your decky client to the "testing" store? If you do that you'll be able to upgrade to steamback 1.1.1. The reason I ask ;-):

The decky folks depend on users to contribute "testing reports" to bless a build to advance to the regular store. Since the only new feature in this build is your good idea you'd probably be an ideal tester to see if it worked for you. If you are willing see https://wiki.deckbrew.xyz/user-guide/testing#submitting-a-test-report and then make a comment using that format on this pull-request: https://github.com/SteamDeckHomebrew/decky-plugin-database/pull/556

It would really help if you could do this.

geeksville commented 5 months ago

(reopening until confirmed working by @goncalossilva)

goncalossilva commented 5 months ago

Happy to help @geeksville! This doesn't seem to be working for me, though. I switched to the testing store, updated Steamback to 1.1.1-0ba8df8, and I don't see the option in an otherwise supported game:

https://github.com/geeksville/steamback/assets/102931/36010f92-1e30-4363-8bc7-19961fbb76d6

(this is in the start screen, but I tried the same in-game right before and same result)

Restarting Steam didn't help. I also noticed scrolling is partially broken (can't scroll all the way up, can't scroll all the way down), though that's probably not related.

goncalossilva commented 5 months ago

I'm not sure how, but the option did eventually pop up!

PXL_20240314_012431051

(looks like it lacks horizontal margin/padding?)

But when I clicked on it, it simply disappeared. It doesn't appear to have done anything.

geeksville commented 5 months ago

hmm - Decky has a current bug that it doesn't properly restart the python code until a full reboot. Would you mind trying a full reboot and then see if clicking on that button works?

On Thu, Mar 14, 2024 at 9:29 AM Gonçalo Silva @.***> wrote:

I'm not sure how, but the option did eventually pop up!

PXL_20240314_012431051.jpg (view on web) https://github.com/geeksville/steamback/assets/102931/77b826bd-5e8a-4e70-8f32-ee5c9bddb147

(looks like it lacks horizontal margin/padding?)

But when I clicked on it, it simply disappeared. It doesn't appear to have done anything.

— Reply to this email directly, view it on GitHub https://github.com/geeksville/steamback/issues/73#issuecomment-1996228563, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXB2NYGQEE5AOLC2PAVR3YYD4NRAVCNFSM6AAAAABDYNH3SKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJWGIZDQNJWGM . You are receiving this because you were mentioned.Message ID: @.***>

goncalossilva commented 5 months ago

Full reboot done, fired up a new game, and it seems to be working!

However, I faced some odd behaviors. I can't exactly tell what's expected or not, so I'll just describe all steps and what happened, and hear from you. :)

  1. Rebooted
  2. Fired up a new game (SANABI)
  3. Played for a while, no button in sight*
  4. Closed the game, auto-save kicked in
  5. Opened the game, the button was now visible (horizontal padding/margin missing*)
  6. Clicked the button
  7. The button disappeared*
  8. It seemed not to do anything, but then I noticed that the save was there, it was simply below another one for "Lies of P", a game I haven't played in a couple of months so I wasn't expecting to see its save above everything else*
  9. Scrolling all the way to the bottom didn't work again*

PXL_20240315_013319376

Marked with "*" are all things I bumped into that were somewhat unexpected. Do you plan to look into them, or should I see the as working as intended and leave feedback on the decky plugin database accordingly?

geeksville commented 5 months ago

@goncalossilva hmm - interesting! thank you for the through writeup. I'll investigate more this week and hopefully figure out what's up.

kmanwar89 commented 4 months ago

I switched over to the testing store for decky loader and installed the latest available version. I saw the button appear exactly once for "backup now" but it has not re-appeared since. and it took a few minutes after re-launching the game for the button to re-appear.

Decky loader v2.11.1, update channel is stable, plugin version 1.1.1-0ba8df8.

Happy to grab any other logs that might help in investigating this

geeksville commented 4 months ago

thanks! alas I had to go out of town suddenly but next week I should be back at my computer and can investigate your great report.

On Mon, Apr 1, 2024 at 1:41 PM Kadar Anwar @.***> wrote:

I switched over to the testing store for decky loader and installed the latest available version. I saw the button appear exactly once for "backup now", but it has not re-appeared since.

Decky loader v2.11.1, update channel is stable, plugin version 1.1.1-0ba8df8.

Happy to grab any other logs that might help in investigating this

— Reply to this email directly, view it on GitHub https://github.com/geeksville/steamback/issues/73#issuecomment-2030519102, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABXB2MO4UDRXH5ADETKEI3Y3HA5VAVCNFSM6AAAAABDYNH3SKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZQGUYTSMJQGI . You are receiving this because you were mentioned.Message ID: @.***>

kmanwar89 commented 4 months ago

Thank you again for creating steamback - I've got 100+ hours into Sekiro save-scumming to prevent myself dying a million deaths :) I do wish the backups were able to be "tagged" so I could just keep reverting to that same backup - similar to savestates in an emulator, each is independent of each other.

Easier said than done, I know, especially since I thought I'd take a look at the code and try to contribute, but it is unfortunately way above my Python skills.

geeksville commented 3 months ago

hi @kmanwar89,

I think I understand:

I switched over to the testing store for decky loader and installed the latest available version. I saw the button appear and it took a few minutes after re-launching the game for the button to re-appear."

I think this may be 'expected behavior' because steamback only shows that button if it sees that the filesystem copies of the saves has changed. Could it be that for your particular game: the game only writes save data occasionally (every few minutes)? Do you have an option you can use in-game to force a save (like a 'save' button)? If you force a save does it then show that steamback can take a new backup?

kmanwar89 commented 3 months ago

hi @kmanwar89,

I think I understand:

I switched over to the testing store for decky loader and installed the latest available version. I saw the button appear and it took a few minutes after re-launching the game for the button to re-appear."

I think this may be 'expected behavior' because steamback only shows that button if it sees that the filesystem copies of the saves has changed. Could it be that for your particular game: the game only writes save data occasionally (every few minutes)? Do you have an option you can use in-game to force a save (like a 'save' button)? If you force a save does it then show that steamback can take a new backup?

Hey, yeah that seemed to be the very initial behavior - I haven't had a single issue using the "backup now" button since. Might have just been the short delay in switching channels that caused the behavior I saw.