geel9 / SteamAuth

A C# library that provides vital Steam Mobile Authenticator functionality
MIT License
278 stars 105 forks source link

GeneralFailure #5

Closed SuperDoker closed 8 years ago

SuperDoker commented 8 years ago

what is it http://i.imgur.com/8Cb9cCh.png

Xeroner commented 8 years ago

It's not solved, why you close it?

shravan2x commented 8 years ago

In most cases, GeneralFailure means a one-time error of some sort. Like the server returning this one "An error occurred while processing your request.". Just retrying your request should work in most cases.

There are some errors that could probably be better off having their own response. For example, TooManyFailedLogins. I have a modified version of the library that has this, but it's completely redesigned so it probably won't do you any good. I have provided fixes for the most common ones below.

First, insert this on line 191 of UserLogin.cs

[JsonProperty("message")]
public string Message { get; set; }

Add this on line 128 on UserLogin.cs after making an enum entry.

if (loginResponse.Message != null && loginResponse.Message.Contains("too many login failures"))
    return LoginResult.TooManyFailedLogins;

There has also been one more exception I've seen it throw which you might want to protect against. Change line 62 of UserLogin.cs to :

if (rsaResponseJson == null || rsaResponseJson.Contains("<BODY>\nAn error occurred while processing your request."))
    session.State = ESessionState.GeneralFailure;
EgoTempest commented 4 years ago

I'm having the endless captcha problem, what was the solution for that? I can't see it listed.

rumblefrog commented 4 years ago

@EgoTempest You do realize this issue is more than 4 years old? And the last commit is a year old?

aleksamagicka commented 4 years ago

This lib is dead, try to find something else

On Tue, Dec 24, 2019 at 6:31 AM rumblefrog notifications@github.com wrote:

@EgoTempest https://github.com/EgoTempest You do realize this issue is more than 4 years old? And the last commit is a year old?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/geel9/SteamAuth/issues/5?email_source=notifications&email_token=ACQGRIPN5N7UIRNR4IRJOH3Q2GNEDA5CNFSM4BVR4EHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHSQTWY#issuecomment-568658395, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQGRIPCRCGRMR2WJSIZEFDQ2GNEDANCNFSM4BVR4EHA .