search

geel9 / SteamAuth

A C# library that provides vital Steam Mobile Authenticator functionality
MIT License
278 stars 105 forks source link

Port for .net core? #53

Open igeligel opened 8 years ago

igeligel commented 8 years ago

Since it is now RTM, is there a chance that this library is getting updated to support .net core?

shravan2x commented 8 years ago

Still has no ARM support ;-;

igeligel commented 8 years ago

Is this a requirement? Anyway we could create the same functionality just in this library with preprocessor directives. Some stuff is not featured in .net core for example HttpWebRequest, this is why a port is really hard.

shravan2x commented 8 years ago

Are you sure HttpWebRequest isn't in .NET Core? I just tried a console app and it seemed to be there.

igeligel commented 8 years ago

The problem is that there is no synchronous support. So you need to change some stuff in this library i believe. Probably other dependencies are not given too.

shravan2x commented 8 years ago

I spent some time with it and think we should wait longer till more libraries pop up. Might not be impossible to do it now though.

igeligel commented 8 years ago

So i want to start with this now. Should i create a new branch for it, a seperate folder or work with conditional compilation?

shravan2x commented 8 years ago

A similar request I made to SteamKit a few days back: https://github.com/SteamRE/SteamKit/issues/299

TL;DR They think we should wait for .NET Standard 2.0 which would make our job much easier.

igeligel commented 8 years ago

It seems like netstandard 2.0 is supporting .net framework 4.6.1. This would be an upgrade of the .net framework in this library. Is geel9 ok with this?

shravan2x commented 8 years ago

Probably will be, I mean - it's way too much work without. Even if SteamAuth managed to remain on 4.5, SteamKit and others will move to 4.6.1. So I don't think it makes sense.

mellowagain commented 7 years ago

As .NET Standard 2.0 got released a while ago and SteamKit also updated to it, is there an update on this issue?

MakcStudio commented 5 years ago

Also interested.. Will it be ported to net standard 2?