search

geelen / jspm-loader-css

50 stars 27 forks source link

Use correct System variable when bundled. #41

Closed elliotlings closed 8 years ago

elliotlings commented 8 years ago

When bundling System is renamed to something like $__System. This fix will check for this.

manveru commented 8 years ago

@geelen any chance you could merge this to fix bundling?

oligot commented 8 years ago

I tested this PR with https://github.com/css-modules/jspm-demo And there is still one single call to System.register in the bundle

System.register("2", [], function($__export) {
  "use strict";
  var __moduleName = "2";
  return {
    setters: [],
    execute: function() {
      $__export('default', {
        "darkblue": "#001f3f",
        "lol": "_src_main__lol _src_backgrounds__lightBlueBackground _src_a__whiteBorder _src_b__fontSize24pt _src_b__dashed-border"
      });
    }
  };
});

@geelen Any idea why it's not using _$_System ?

oligot commented 8 years ago

I just found that the problem will be solved when PR #44 is merged.

juliogarciag commented 8 years ago

It's merged. What is missing is a release.