search

geelen / jspm-loader-css

50 stars 27 forks source link

Why is __moduleName given to CSSLoader? #43

Closed MeoMix closed 8 years ago

MeoMix commented 8 years ago

The variable __moduleName is passed into CSSLoader's constructor and stored as a private variable, _moduleName, but it is then never used.

Is this just sloppy coding? Or were their plans for it in the future that didn't make it into this?

geelen commented 8 years ago

The idea was that jspm-loader-css-modules would reuse jspm-loader-css but when it found an :import directive it would need to know to load using the right loader. But I think there's a better way to do this now.

MeoMix commented 8 years ago

I'll go ahead and remove it on muh branch.

MeoMix commented 8 years ago

Removed on muh branch.