search

geelen / jspm-loader-css

50 stars 27 forks source link

CSS minification #7

Open guybedford opened 9 years ago

guybedford commented 9 years ago

This is a feature we have in the main plugin currently when running a build via the bundle hook. It would be good to maintain this support.

geelen commented 9 years ago

Is it configurable or does it just always run?

guybedford commented 9 years ago

It always runs because we rely on cleanCSS, but ideally it should only run when opts.minify is set.

See https://github.com/systemjs/plugin-css/blob/master/css-builder.js#L43.

I've combined minify and advanced optimizations into one boolean, although this should probably remain separate in a more separated implementation.

geelen commented 9 years ago

I didn't even know build took options! How do you trigger them from the JSPM cli?

guybedford commented 9 years ago

It's actually just the jspm bundle -m option - a fixed build option that is.

oligot commented 8 years ago

Just to let you know that I've created a pull request for this issue: #49