Closed MCDELTAT closed 1 year ago
This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!
Please read this blog post to see the reasons why I mark pull requests as stale.
This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.
This pull request provides a unified location to handle the conversion between temperature units. Currently, the metrics endpoint remained in Celcius even if the display showed Fahrenheit by user choice.
It's been a while since I've used C++, so let me know if the standards for naming things are off, but it seems like functions and variables are Lower Camel Case, while Types (classes, structs) are Upper Camel Case.
See: https://google.github.io/styleguide/cppguide.html