search

geerlingguy / ansible-role-certbot

Ansible Role - Certbot (for Let's Encrypt)
https://galaxy.ansible.com/geerlingguy/certbot/
MIT License
793 stars 348 forks source link

do not use cron when installing from distribution on Debian #147

Closed xiruizhao closed 1 year ago

xiruizhao commented 3 years ago

Debian distribution package provides a systemd timer for certificate auto renewal

maxtruxa commented 3 years ago

I work around this by setting certbot_auto_renew: false on Debian, but it sure would be nice to have this behavior by default.

stale[bot] commented 3 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

maxtruxa commented 3 years ago

Still relevant.

stale[bot] commented 3 years ago

This issue is no longer marked for closure.

evilhamsterman commented 3 years ago

I think a better way of doing this would be to create a file in vars called Debian.yml with the line certbot_auto_renew: false. @geerlingguy's roles will pull from vars files named after the ansible_os_family for distro or family specific features.

stale[bot] commented 2 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

evilhamsterman commented 2 years ago

Still relevant

stale[bot] commented 2 years ago

This issue is no longer marked for closure.

stale[bot] commented 2 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

rotanid commented 2 years ago

still relevant

stale[bot] commented 2 years ago

This issue is no longer marked for closure.

markstos commented 2 years ago

I ran this playbook on Ubuntu and then used systemctl list-timers to confirm certbot.timer was present and runing and it was. I recommend merging this.

evilhamsterman commented 2 years ago

@geerlingguy I know you are very busy but this is a very simple fix that has been sitting for a long time. Can you either accept this PR or add certbot_auto_renew: false to your Debian.yml vars file?

xiruizhao commented 2 years ago

See https://packages.debian.org/bullseye/all/certbot/filelist (debian 11.4), https://packages.debian.org/stretch/all/certbot/filelist (debian 9.3)

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

rotanid commented 1 year ago

still relevant

stale[bot] commented 1 year ago

This issue is no longer marked for closure.

xiruizhao commented 1 year ago

Distribution package users with systemd timers should turn off certbot_auto_renew.

markstos commented 1 year ago

This is commonly installed directly with Ansible. The role supports Debian already, and replacing systemd timers with cron a better choice on Debian and should be set in the role itself.