search

geerlingguy / ansible-role-certbot

Ansible Role - Certbot (for Let's Encrypt)
https://galaxy.ansible.com/geerlingguy/certbot/
MIT License
780 stars 346 forks source link

Add "--expand" option for Certbot #171

Closed amotl closed 2 years ago

amotl commented 2 years ago

Dear Jeff,

we want to salute you once more for one of your excellent contributions to the Ansible community in form of this recipe.

Because we want to aim at maximum DWIM by implementing our systems automation infrastructure with Ansible, we are in dire need of support for the --expand option of Certbot, using its webroot method. So, we picked up the contribution #117 by @ymarkus (thanks a stack!), wrapped it up and added corresponding support for webroot.

After that, expanding the list of certbot_certs.domains by another item and re-running the corresponding playbook immediately resolved the problem for us, where, beforehand, another subdomain was added to the list and the recipe was not able to pick up the change, without reporting back any kind of error.

We hope you will like the patch. I will add some comments to the PR, where I believe details about the implementation should be discussed. Thank you for taking the time to look into this!

With kind regards, Andreas.

Others also needing this: In order to install the improvements in this branch into your Ansible environment, you might either want to invoke

ansible-galaxy install git+https://github.com/cicerops/ansible-role-certbot.git,expand

or add this to your requirements.yaml file:

roles:

  - name: geerlingguy.certbot
    src: git+https://github.com/cicerops/ansible-role-certbot
    version: expand
stale[bot] commented 2 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 2 years ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.