search

geerlingguy / ansible-role-certbot

Ansible Role - Certbot (for Let's Encrypt)
https://galaxy.ansible.com/geerlingguy/certbot/
MIT License
793 stars 348 forks source link

setup-RedHat.yml #190

Closed mprusov closed 10 months ago

mprusov commented 1 year ago

Probably the code:

  - name: Enable DNF module for CentOS 8.3+.
    shell: |
      dnf config-manager --set-enabled powertools
    register: dnf_module_enable
    changed_when: false

    when: ansible_facts['distribution_version'] is version('8.3', '>=')

  - name: Enable DNF module for CentOS 8.0–8.2.
    shell: |
      dnf config-manager --set-enabled PowerTools
    register: dnf_module_enable
    changed_when: false

when: ansible_facts['distribution_version'] is version('8.2', '<=')

should be:

  - name: Enable DNF module for CentOS 8.3+.
    shell: |
      dnf config-manager --set-enabled powertools
    register: dnf_module_enable
    changed_when: false
    when: ansible_facts['distribution_version'] is version('8.3', '>=')

  - name: Enable DNF module for CentOS 8.0–8.2.
    shell: |
      dnf config-manager --set-enabled PowerTools
    register: dnf_module_enable
    changed_when: false
    when: ansible_facts['distribution_version'] is version('8.2', '<=')

?

csuka commented 1 year ago

Yes, I guess so too.
And your title should be, setup-RedHat.yml 👯‍♂️

stale[bot] commented 1 year ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

stale[bot] commented 1 year ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

stale[bot] commented 1 year ago

This issue is no longer marked for closure.

StefanIGit commented 1 year ago

That's why I add my "when"s on top under the name ;) Anyway, any plans to support CentOS 9?

github-actions[bot] commented 1 year ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

github-actions[bot] commented 10 months ago

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.