geerlingguy / ansible-role-certbot

Ansible Role - Certbot (for Let's Encrypt)
https://galaxy.ansible.com/geerlingguy/certbot/
MIT License
780 stars 346 forks source link

5.1.1 not published on ansible galaxy #210

Open gclawes opened 4 months ago

gclawes commented 4 months ago

Version 5.1.1 with certbot_create_extra_args support is not published on Ansible Galaxy: https://galaxy.ansible.com/ui/standalone/roles/geerlingguy/certbot/versions/

chrisdecker1201 commented 4 months ago

Here is the action that failed: https://github.com/geerlingguy/ansible-role-certbot/actions/runs/7416948318

JoeNyland commented 3 months ago

I've worked around this issue by installing 5.1.1 from GitHub, rather than Ansible Galaxy:

diff --git a/requirements.yml b/requirements.yml
index 31e64a7..8d978f0 100644
--- a/requirements.yml
+++ b/requirements.yml
@@ -41,5 +41,7 @@ roles:
   - name: joenyland.zfs
     src: https://github.com/JoeNyland/ansible-zfs-role
   - name: geerlingguy.certbot
+    src: https://github.com/geerlingguy/ansible-role-certbot
+    version: 5.1.1
   - src: nginxinc.nginx
   - src: nginxinc.nginx_config

I understand this doesn't fix it, but it at least allows me to use certbot_create_extra_args to use an internal ACME server URL.

geerlingguy commented 1 month ago

Oh wow, sorry about this! Please feel free to ping me if you find something broken like this — I will release a new tag, unfortunately I can't re-run the previous tag easily.

JoeNyland commented 1 month ago

No worries Jeff. I think we just didn't want to pester you 🙂

geerlingguy commented 1 month ago

@JoeNyland I'm happy getting pestered when it's a small / actionable request. Less so when someone wants their 300 line code change for an obscure new feature reviewed, haha!