search

geerlingguy / ansible-role-docker

Ansible Role - Docker
https://galaxy.ansible.com/geerlingguy/docker/
MIT License
1.81k stars 854 forks source link

update for arm and docker-compose v2 and above #329

Closed Lithimlin closed 2 years ago

Lithimlin commented 2 years ago

Role now is able to handle arm architectures like from a Raspberry Pi. This includes automatic architecture detection. Also includes capabilities of installing docker-compose versions 2 and above.

geerlingguy commented 2 years ago

This PR seems to be adding two features which makes it a little less likely to get merged (one of the two at least)—I just merged a PR to at least allow some arch-specific configuration to be changed (see #319), and please see https://github.com/geerlingguy/ansible-role-docker/issues/304 for discussion about Compose v2 (which I'd rather add in its own PR too).

Lithimlin commented 2 years ago

Ah, I hadn't realized that the commands of compose v2 changed so much since I installed it a while ago and also used the compose-switch. Since compose v2 is not (yet) supported by the ansible docker-compose module though it might be questionable to install it anyway. I'll split this PR into two and probably add a note to the README addressing this issue.

https://github.com/geerlingguy/ansible-role-docker/issues/304#issuecomment-945557008 hints at an issue with my automatic architecture implementation. I don't have a Pi Zero so I wasn't able to test this with an armv6 and it seems there is an extra 1 there. I'll still open up a PR though and ask people to test it.

All this might take a few days.

Lithimlin commented 2 years ago

I've split this PR into two (#330 and #331). The compose v2 support is not yet added as it would profit from either the compose-switch or the compose docker plugin (see https://github.com/geerlingguy/ansible-role-docker/issues/304#issuecomment-944468757)