search

geerlingguy / ansible-role-docker

Ansible Role - Docker
https://galaxy.ansible.com/geerlingguy/docker/
MIT License
1.81k stars 854 forks source link

Arch detect #330

Closed Lithimlin closed 1 year ago

Lithimlin commented 2 years ago

Split of #329:

Role now is able to handle arm architectures like from a Raspberry Pi. This includes automatic architecture detection.

Lithimlin commented 2 years ago

Update: now also includes the automatic architecture for docker-compose

stale[bot] commented 2 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

MrSuicideParrot commented 2 years ago

I think this pull request could be improved by removing the dpkg dependence. According to the source.list documentation you can use something like $(ARCH), which will expand to the platform architecture.

suite may also contain a variable, $(ARCH) which expands to the Debian architecture (such as amd64 or armel) used on the system. This permits architecture-independent sources.list files to be used. In general this is only of interest when specifying an exact path; APT will automatically generate a URI with the current architecture otherwise.

Source: http://manpages.ubuntu.com/manpages/jammy/en/man5/sources.list.5.html

stale[bot] commented 2 years ago

This issue is no longer marked for closure.

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 1 year ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.