geerlingguy / ansible-role-docker

Ansible Role - Docker
https://galaxy.ansible.com/geerlingguy/docker/
MIT License
1.81k stars 853 forks source link

Add filename option to apt repository add #368

Closed kaysond closed 11 months ago

kaysond commented 2 years ago

Addresses #335 and #101 (i.e. I'd say it's technically a work around as opposed to a solution)

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

kaysond commented 1 year ago

Not stale

stale[bot] commented 1 year ago

This issue is no longer marked for closure.

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

kaysond commented 1 year ago

not stale (unless superseded by #369)

stale[bot] commented 1 year ago

This issue is no longer marked for closure.

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

kaysond commented 1 year ago

not stale

stale[bot] commented 1 year ago

This issue is no longer marked for closure.

dsegurag commented 1 year ago

@geerlingguy, @kaysond what if we add something like filename: "{{ docker_apt_filename | default(omit) }}", and we don't need to set anything under "default" folder:

- name: Add Docker repository.
  apt_repository:
    repo: "{{ docker_apt_repository }}"
    filename: "{{ docker_apt_filename | default(omit) }}"
    state: present
    update_cache: true
  when: docker_add_repo | bool

It's backward compatible with the current code. For next major version we can set a name (maybe "docker") for the file, but meanwhile people can start changing it to the desired name.

kaysond commented 11 months ago

Superseded by #369