search

geerlingguy / ansible-role-docker

Ansible Role - Docker
https://galaxy.ansible.com/geerlingguy/docker/
MIT License
1.81k stars 853 forks source link

Upgrade the OpenPGP key retrieval #381

Closed ictus4u closed 1 year ago

ictus4u commented 1 year ago

As the apt-key method has been deprecated, this commit includes the recommended signed-by directive in the repository definition.

Followed the tips here: https://www.linuxuprising.com/2021/01/apt-key-is-deprecated-how-to-add.html

geerlingguy commented 1 year ago

Please see: https://www.jeffgeerling.com/blog/2022/aptkey-deprecated-debianubuntu-how-fix-ansible

Until https://github.com/ansible/ansible/issues/78063 is fixed, I'd rather not change the setup for this process.

ictus4u commented 1 year ago

Oh, I see. Thank you for pointing out the ongoing discussion. I've seen the --dearmor approach is under debate. However, please consider that without the signed-by directive pointing to a separate non-widely trusted file, we keep the cause for the deprecation in the first place: the risk of cross-signing. The https://github.com/tonyclemmey/ansible-role-mongodb/commit/ca676ed235f21de8041ec2f99baeadc02e08248b solution goes in the way of avoiding to --dearmor but is honoring the signed-by requirement. If you find it worth it, I could make another PR.

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

stale[bot] commented 1 year ago

This pull request has been closed due to inactivity. If you feel this is in error, please reopen the pull request or file a new PR with the relevant details.