geerlingguy / ansible-role-docker

Ansible Role - Docker
https://galaxy.ansible.com/geerlingguy/docker/
MIT License
1.81k stars 853 forks source link

Add a variable to prevent auto-start on package installation #395

Closed lel-amri closed 1 year ago

lel-amri commented 1 year ago

At the time of committing :

This commit adds the docker_service_prevent_autostart variable. When set to true, prevents service start on package installation.

lel-amri commented 1 year ago

This is my first contribution to an Ansible role. This might not be the way to do things with ansible.builtin.package. Commit message might have grammar errors. I'm open to any comment regarding this PR as a whole.

I need this option so I can prevent the service from starting when installed on Debian in rootless-only installations. I don't want the service to start system-wide, ever. I actually mask the service files before installation, which causes an error on installation because the .deb postinst script tries to start the service.

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

lel-amri commented 1 year ago

Bump

stale[bot] commented 1 year ago

This issue is no longer marked for closure.

stale[bot] commented 1 year ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

github-actions[bot] commented 1 year ago

This pr has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.