search

geerlingguy / ansible-role-docker

Ansible Role - Docker
https://galaxy.ansible.com/geerlingguy/docker/
MIT License
1.81k stars 853 forks source link

Debian: add `signed-by` param to the apt list #409

Closed aine-etke closed 1 year ago

aine-etke commented 1 year ago

Role already uses the /etc/apt/trusted.gpg.d/docker.asc, so why not add signed-by param to the /etc/apt/sources.list.d/download_docker_com_linux_ubuntu.list?

Current behavior:

# /etc/apt/sources.list.d/download_docker_com_linux_ubuntu.list
deb [arch=amd64] https://download.docker.com/linux/ubuntu jammy stable

Desired behavior:

# /etc/apt/sources.list.d/download_docker_com_linux_ubuntu.list
deb [arch=amd64 signed-by=/etc/apt/trusted.gpg.d/docker.asc] https://download.docker.com/linux/ubuntu jammy stable
aine-etke commented 1 year ago

added PR with fix

github-actions[bot] commented 1 year ago

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

aine-etke commented 1 year ago

@geerlingguy could you check it, please? The fix is ready and just needs to be merged