search

geerlingguy / ansible-role-docker

Ansible Role - Docker
https://galaxy.ansible.com/geerlingguy/docker/
MIT License
1.8k stars 851 forks source link

feat: use `ansible_facts` rather than `variables` #423

Open jackhodgkiss opened 11 months ago

jackhodgkiss commented 11 months ago

This PR addresses the issue raised in #422 by replacing ansible_ with ansible_facts. counterparts.

Has been tested numerous times within Ubuntu 22.04.

markgoddard commented 11 months ago

LGTM

geerlingguy commented 11 months ago

Seems like there's a merge conflict—happy to merge once that's fixed up!

jackhodgkiss commented 10 months ago

Merge conflict resolved.

markgoddard commented 10 months ago

How's this looking now @geerlingguy?

github-actions[bot] commented 6 months ago

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

markgoddard commented 6 months ago

@geerlingguy please could you merge this one? Thanks

github-actions[bot] commented 1 month ago

This pr has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark issues as stale.

markgoddard commented 1 month ago

:(