search

geerlingguy / ansible-role-docker

Ansible Role - Docker
https://galaxy.ansible.com/geerlingguy/docker/
MIT License
1.8k stars 851 forks source link

Recent role update does not remove previous versions of the apt key, and so duplicate apt keys are created on Debian #460

Open danrough opened 2 months ago

danrough commented 2 months ago

In #436 the path that the Docker apt key was changed from /etc/apt/trusted.gpg.d/ to /etc/apt/keyrings. For those of us who favour always using the latest version of the role, rather than pinning a specific version, this means that the key that the role previously installed in /etc/apt/trusted.gpg.d/ remains and so a duplicate is created. This then results in errors from apt when running apt update, for e.g.

cschindlbeck commented 1 month ago

Something along the lines of https://github.com/geerlingguy/ansible-role-docker/pull/464 could help, although i don't like the code duplication in the vars... EDIT: nevermind, you already opened a MR here https://github.com/geerlingguy/ansible-role-docker/pull/461