search

geerlingguy / ansible-role-elasticsearch

Ansible Role - Elasticsearch
https://galaxy.ansible.com/geerlingguy/elasticsearch/
MIT License
185 stars 209 forks source link

Make configuration of ElasticSearch more dynamic #20

Closed leifmadsen closed 7 years ago

leifmadsen commented 8 years ago

Currently the usage of the lineinfile module just makes the configuration of ES somewhat awkward and more difficult than it really needs to be.

A better approach would be to use a template.

leifmadsen commented 8 years ago

I've added a PR for this issue, but it's not yet complete as I have to update the documentation, and go through the other open PRs to mark them as deprecated in favour of this one (assuming the approach is accepted).

davidak commented 7 years ago

The PR is merged so this should be closed.

geerlingguy commented 7 years ago

@davidak - Great, thanks for reminding me!