search

geerlingguy / ansible-role-elasticsearch

Ansible Role - Elasticsearch
https://galaxy.ansible.com/geerlingguy/elasticsearch/
MIT License
185 stars 209 forks source link

Elasticsearch Version configurable #8

Closed remuslazar closed 8 years ago

remuslazar commented 8 years ago

This PR makes the Elasticsearch Version to be installed (only for Debian distros) configurable via the variable "elasticsearch_version".

The default value is 1.4, for backwards compatibility.

geerlingguy commented 8 years ago

Can you also add documentation inside the README for this new variable, along with a note that this variable only applies to Debian/Ubuntu (not to RedHat/CentOS)?

remuslazar commented 8 years ago

@geerlingguy to be honest, this was quite a "hack" to get the ES 1.7 version installed. I then created the PR because, despite of the fact that it will fork just for Debian, it's anyway better than having the 1.4 magic string hardcoded..

It will be definitely cooler to use a role variable for the desired version like 1.x, 2.x, latest, 1.5 and so on.

geerlingguy commented 8 years ago

The version is using a major ES version at this point; 2.x as of this writing. I think that's adequate since we're using ES's main repository, and major version changes (e.g. 3.x) will require some role rearchitecture anyways.

baschny commented 7 years ago

@geerlingguy some "legacy projects" might require older versions, so the "last stable" might not be the one we need :) so being able to choose between the "major version" at least would be desirable.