search

geerlingguy / ansible-role-elasticsearch

Ansible Role - Elasticsearch
https://galaxy.ansible.com/geerlingguy/elasticsearch/
MIT License
185 stars 208 forks source link

install specific elasticsearch version #83

Closed bilalcaliskan closed 3 years ago

bilalcaliskan commented 3 years ago

Which issue(s) this PR fixes:

this pr solve issue #81 .

What this PR does / why we need it:

This PR creates an additional variable called elasticsearch_package_version which defaults to 7.10.2 to be able to install specific version of elasticsearch instead of latest version in the elasticsearch 7.x repositories.

Special notes for your reviewer:

I have also modified the README.md

bilalcaliskan commented 3 years ago

@geerlingguy could you please review that PR?

Regards.

bilalcaliskan commented 3 years ago

@geerlingguy can you help with the approval?

giuseppemorelli commented 3 years ago

@geerlingguy this PR will help a lot of people :) Please take a look

stale[bot] commented 3 years ago

This pull request has been marked 'stale' due to lack of recent activity. If there is no further activity, the PR will be closed in another 30 days. Thank you for your contribution!

Please read this blog post to see the reasons why I mark pull requests as stale.

bilalcaliskan commented 3 years ago

@geerlingguy could you take a look of that PR?

stale[bot] commented 3 years ago

This issue is no longer marked for closure.

mdubakin commented 3 years ago

@geerlingguy Hello! This feature is really useful and necessary, could you please accept the pull request? Thank you!

bilalcaliskan commented 3 years ago

@mdubakin @giuseppemorelli you can use the forked version here . I guess @geerlingguy is closed to open source contributions :(

geerlingguy commented 3 years ago

@bilalcaliskan - It's not that I'm closed to contributions, it's that sometimes a contribution (e.g. a feature like this) doesn't line up with my priorities, and I'll sometimes get to it, other times not, but typically I prioritize in my merge list:

  1. Things that make the role completely break (e.g. bug with existing feature and CI fails).
  2. Things that affect my workflow.
  3. Things that are one-line fixes I can review and test in seconds or a couple minutes max.

Any other feature addition adds not only the (sometimes) small overhead of my own testing and adjustment, it also carries a lifetime maintenance cost where it was not there before.

And I'm very clear that I license my roles with the most liberal license possible, because I know they are not perfect for every use case—they're just perfect for mine ;)

bilalcaliskan commented 3 years ago

@geerlingguy thanks for the detailed explanation. I would like to hear what is wrong with that PR, i think it does not violate any of the reasons you mentioned but i may be wrong of course.

Also i am not so senior on open source contribution world so i am very open to positive/negative feedbacks.

geerlingguy commented 3 years ago

Any other feature addition

However, I'm considering this PR, I just haven't had time to fully review it :)

bilalcaliskan commented 3 years ago

@geerlingguy looking forward for it :)